postgresql: use team #352905
postgresql: use team #352905
Conversation
| @@ -320,7 +320,7 @@ let | |||
| description = "Powerful, open source object-relational database system"; | |||
| license = licenses.postgresql; | |||
| changelog = "https://www.postgresql.org/docs/release/${finalAttrs.version}/"; | |||
| maintainers = with maintainers; [ thoughtpolice danbst globin ivan ma27 wolfgangwalther ]; | |||
| maintainers = with maintainers; [ danbst globin ivan ] ++ teams.postgres.members; | |||
There was a problem hiding this comment.
Let's also take the chance to discuss / ask about the other maintainers listed here. My experience over this year was, that nobody else except @Ma27 ever commented on any of the related Pull Requests I made - which is absolutely fine. In the beginning it was just confusing to me, because the package looked well maintained from looking at the list of maintainers - but it turned out not to be true.
Looking at activity in nixpkgs in general and at postgresql specifically, I think we should:
- Remove @danbst from the list of maintainers, last active in nixpkgs in ~2020 (pull requests, commits).
- Check-in with @globin, who committed to nixpkgs as of July this year, but apparently never had any PRs related to PostgreSQL. @globin do you still want to be a maintainer for PostgreSQL? Seems like this could be a case of "I'd like to be notified about changes", in which case I'd suggest we add a comment accordingly, so that people looking at the list can tell they wouldn't need to expect an answer / review here?
- Check-in with @ivan who recently removed himself from
postgresqlPackages.pg_embeddingin prisma-engines, postgresqlPackages.pg_embedding: remove myself from maintainers #324978. @ivan did you just forget to remove yourself here or would you like to remain maintainer forpostgresql? - Check-in with @thoughtpolice - you still seem to be very active on nixpkgs, but haven't heard anything from you in the context of
postgresql. Would you (still) like to be part of the postgresql team?
There was a problem hiding this comment.
I still do use postgres-with-nix behind the scenes and even did some commercial work on it last year, but mostly it's just because I'm spread very thin and don't have time to give it singular focus and many of the PRs require much more attention than I have available.
I'm happy to remain on the maintainers list as a point-of-contact for questions though.
ofborg
bot
added
10.rebuild-darwin: 0
|
@wolfgangwalther just created a team for postgres with all members in this branch. What do we do with the other maintainers? It's not super-urgent to merge it now, but I'd like to not stall this because we're awaiting feedback. |
| /pkgs/servers/sql/postgresql @NixOS/postgres | ||
| /nixos/modules/services/databases/postgresql.md @NixOS/postgres | ||
| /nixos/modules/services/databases/postgresql.nix @NixOS/postgres | ||
| /nixos/tests/postgresql.nix @NixOS/postgres |
There was a problem hiding this comment.
Perhaps we want to move all postgresql-related tests into nixos/tests/postgresql? That way, we could also add the subtree here.
There was a problem hiding this comment.
Even with #352966 open, I think it should be fine to move those files here. A rebase should be simple, because git should detect the renames.
Let's remove danbst as suggestd above in this PR, then merge. We'll still wait for feedback here and if we don't get any we will remove the others later? |
|
Done. |
👍 |
Main motivation for this is that I'd like to get a feature-freeze ping: we have old stuff to remove and quite a bit of things ongoing here, so explicitly being part of the check-up process seems like a good thing. Also added myself and wolfgangwalther to it.
Thanks a lot for all your work! If you ever come back to nixpkgs, feel free to revert the commit, your return would be welcomed!
|
So, the team exists, I now need somebody to add nixpkgs in read-only mode to be added to the team:
cc @Lassulus @zimbatm can one of you add nixpkgs (role: readonly) to https://github.com/orgs/NixOS/teams/postgres ? |
It will be EOL in about a week[1] and should've never reached 24.11. However, I messed up and missed the freeze deadline, so we can't do breaking stuff like this, hence we'll mark it as insecure and right after branchoff it will be removed from unstable. During that discussion I also got the feedback that it's easy for people who just do `services.postgresql.enable = true;` to miss their version getting EOL since there's no warning by the selection logic based on the state version. Also added that. It's kinda noisy, but I expect it to be pretty effective for people who are prone to miss the EOL otherwise. For 25.11 I'd like to make sure we remove postgresql_13 before. To make it harder for us to miss the deadline, the postgres team will receive a ping before feature freeze[2]. [1] https://endoflife.date/postgresql [2] Implemented in NixOS#352905
wegank
added
the
12.approvals: 1
|
While you're on this, could you remove me from postgis and pg_safeupdate as maintainer together with the addition of the team? We only added myself, so that I would be notified about potential breaking changes there, but with the postgres team in ci/OWNERS, I will be notified anyway. |
|
@Ma27 I see a 👍 by lassulus on:
Can you trigger CI again? |
No response for 3 weeks to: NixOS#352905 (comment)
Main motivation for this is that I'd like to get a feature-freeze ping: we have old stuff to remove and quite a bit of things ongoing here, so explicitly being part of the check-up process seems like a good thing.
Also added myself and wolfgangwalther to it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.